Skip to content

Aligned workflow/docs with the default branch name #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2021
Merged

Aligned workflow/docs with the default branch name #8

merged 1 commit into from
Feb 11, 2021
+11 −35

Conversation

kittaakos
Copy link
Contributor

This is required after switching the default from master to main.

Signed-off-by: Akos Kitta [email protected]

Changes:

  • Updated the workflow,
  • Updates the doc,
  • Removed the Gitpod file.

Acceptance criteria:

  • The workflow should automatically start for this PR.

Please review. Thank you!

Aligned workflow/docs with the default branch name
8289cc6 
This is required after switching the default from `master` to `main`.

Signed-off-by: Akos Kitta <[email protected]>
@kittaakos kittaakos requested review from per1234 and rsora February 11, 2021 13:23
rsora
rsora approved these changes Feb 11, 2021
View reviewed changes
Copy link
Contributor

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

per1234
per1234 approved these changes Feb 11, 2021
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Akos!

The only thing I was not able to evaluate was the removal of /.gitpod.yml, since I'm not familiar with Gitpod.

@kittaakos
Copy link
Contributor Author

The only thing I was not able to evaluate was the removal of /.gitpod.yml, since I'm not familiar with Gitpod.

Thanks for noting it, Per. I removed it because the IDE cannot run in a browser environment as of today. Right now, it is just noise and could be misleading once the project goes public. I am happy to restore it, once we need it.

@kittaakos kittaakos merged commit b3deb2f into main Feb 11, 2021
@kittaakos kittaakos deleted the adjust-gh-actions-to-default-main branch February 11, 2021 14:12
@kittaakos kittaakos mentioned this pull request Feb 11, 2021
Closed
@per1234 per1234 added topic: documentation Related to documentation for the project topic: infrastructure Related to project infrastructure labels Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

@rsora rsora rsora approved these changes

Assignees
No one assigned
Labels
topic: documentation Related to documentation for the project topic: infrastructure Related to project infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kittaakos @per1234 @rsora